What Does This Do

Coverage is now enabled if the testJvm matches the daemon JDK (as before), but now also when explicitly requested via checkCoverage property which is consulted when the aggregate test task is being configured, but never was in the test jvm build extension.

Motivation

Code coverage was explicitly disabled when the testJvm was run on a different JDK.

Coverage was disabled as a side effect of the old multi-JDK test optimization.

When -PtestJvm was introduced, the intent was to run the same Gradle Test tasks on another JDK instead of creating separate test tasks per JDK. For those additional JVM runs, Jacoco was explicitly disabled to avoid paying coverage instrumentation cost across the whole compatibility matrix. That made sense when coverage was expected to run only once, on the normal/base test JVM.

The problem is that CI later also passed -PtestJvm=8 to the coverage job. While that was mostly harmless, once the daemon moved to a newer JDK, Java 21, the gitlab-ci condition if [ "$testJvm" == "8" ]; then export GRADLE_PARAMS="-PskipFlakyTests -PcheckCoverage"; fi was applied, but then made the Java 8 a real test launcher. Which then deactivated jacoco.

Additional Notes

Instrumentations were deliberately not covered by jacoco, so only base_tests job is affected.

History of related changes

• Rework the way multi-jvm tests work #522
• Optimize circleci resource_class and run instrumentation tests as a separate task #2710
• Restructure MultiJDK testing to override JDK instead of creating tasks #3417
• Fix test selection logic with coverage #7467
• Introduces testJvmConstraints Gradle extension to replace extra properties #9892
• Bump spotbugs gradle plugin to 6.4.7 #10025 (Gradle daemon JDK bump to Java 21)
  • this was reverted and re-applied here Re-apply "Bump spotbugs gradle plugin to 6.4.7 (#10025)" #10074

Coverage fix PRs

• Cover continuation and listener behaviour when registering no-op manager during tests #11762
• Improve test coverage for CiVis classes #11768
• Exclude ServiceNameSources from coverage #11769
• Exclude patched OkHttp classes and trivial I/O classes from coverage #11770
• Extend OTLP HTTP coverage to GRPC #11771
• Add coverage for ForeignMemoryWriterFactory #11772
• Cover decoded trace sampling priority. #11773
• Enable and fix test coverage for SCA types in internal API #11774
• Add coverage and exclusions for dsm classes #11775
• Cover disabled ratelimited logging. #11776
• Exclude ProfilerContext from coverage #11777
• Add missing coverage tests for OptimizedTagMap and EntryReadingHelper #11778
• Add missing coverage tests for Hashtable.D2 #11779
• Add missing coverage tests for Matchers.AnyMatcher primitive overloads #11780
• Update Code Coverage for config-utils #11781
• Remove default methods from CoreSpan; implement them in test doubles #11782
• Test explicit histogram boundaries and per-thread recordings #11783
• Add FFE flag map adapter coverage #11784
• Increase SCA vulnerability test coverage #11785
• Extend WellKnownTagsTest coverage and migrate it to Java #11790
• Extend W3CTraceParentTest coverage and migrate it to Java #11791
• Add LLMObsContextTest #11792
• Add direct coverage tests for Hashtable.D2.Entry #11794
• Exclude OptimizedTagMap.EmptyHolder from coverage checks #11795
• Add TemporaryRequestContext unit tests #11798
• Add test coverage exclusion for ClientIpAddressData #11799
• Add MessageAdapter content parts serialization test coverage #11800
• Add ProtocolVersion tests and exclude specific classes from coverage #11801
• Add 128 bit TID parsing tests #11802